Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.18 tracking #444

Closed
wants to merge 14 commits into from
Closed

v0.18 tracking #444

wants to merge 14 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 16, 2022

Pulling in both #414 and #437 here. Mainly because I want to use them and don't want to merge them into master just yet. I'll do #414 when 0.17.0 is done though.

rvagg added 14 commits June 16, 2022 18:02
… kinds

also adds tests, and typed functions that must be used in the interface
Can handle maps, lists and all scalar kinds; a receiving Go type that is
registered as a CustomTypeAnyConverter will receive a datamodel.Node and is
expected to return one when converting to and from that custom Go type.
For centralising bindnode setup - register a type & schema once and not have to
worry about the TypedPrototype or direct bindnode calls after that. It also
caches bindnode Options that may go along with the type.

This could have been a global registry, but there exists a possibility of the
same type wanting to be used by different users in the same application
instance but with different schemas and/or Options. So instead, the question of
it being a global is left to the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant